improvement: Try to optimize coverage phase #24925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchyb
reviewed
Jan 9, 2026
Contributor
jchyb
left a comment
jchyb
left a comment
There was a problem hiding this comment.
Overall looks great, I've noticed one improvement that could simplify things
compiler/src/dotty/tools/dotc/transform/InstrumentCoverage.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/transform/InstrumentCoverage.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/transform/InstrumentCoverage.scala
Outdated
Show resolved
Hide resolved
tgodzik
force-pushed
the
optimize-coverage
branch
from
f2b1680 to
ea5a84b
Compare
tgodzik
force-pushed
the
optimize-coverage
branch
from
ea5a84b to
556e33e
Compare
jchyb
approved these changes
Jan 9, 2026
|
@tgodzik This is awesome, thanks! 👍 Do you think it would be possible to backport this to 3.8.1 (probably in time for the RC2)? 🙂 |
tgodzik
added
the
backport:nominated
Contributor
Author
|
I think we can if there is an RC2. |
Contributor
Author
|
I was worried it was too fast and I broke something, but double checking it seems ok. We should be able to backport |
WojciechMazur
pushed a commit
that referenced
this pull request
Jan 13, 2026
WojciechMazur
added
backport:accepted
WojciechMazur
added a commit
that referenced
this pull request
Jan 13, 2026
Backports #24925 to the 3.8.1-RC1. PR submitted by the release tooling. [skip ci]
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main optimization is to only deserialize and serialize coverage files once. Tested it locally and it did seem to help.
Should help with #24909